MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 23 Pull Requests 1 Releases 2 Wiki Activity

Cancel Stalled throws a fatal error (protected CMSApplication::getContainer()) #306

New Issue
Open
opened 2026-07-18 20:17:35 +00:00 by jmiller · 1 comment
jmiller commented 2026-07-18 20:17:35 +00:00
Owner
Copy Link
Copy Source

Type: bug Priority: high Component: com_mokosuitebackup

Summary

Clicking Backup Records → Cancel Stalled dies with a fatal:

Call to protected method Joomla\CMS\Application\CMSApplication::getContainer() from scope Joomla\Component\MokoSuiteBackup\Administrator\Controller\BackupsController

There is therefore no working UI path to clear a stuck backup.

Root cause

BackupsController::cancelStalled() and purge() fetch the DB via $this->app->getContainer(), but CMSApplication::getContainer() is protected.

Fix

Use Factory::getContainer() (as the rest of the component already does). Both call sites corrected on branch fix/backup-cancel-stall-runbackup-updatesite.

Repro

  1. Have a backup record in running state.
  2. Backup Records → select it → Cancel Stalled → fatal.
**Type:** bug **Priority:** high **Component:** com_mokosuitebackup ### Summary Clicking **Backup Records → Cancel Stalled** dies with a fatal: > Call to protected method `Joomla\CMS\Application\CMSApplication::getContainer()` from scope `Joomla\Component\MokoSuiteBackup\Administrator\Controller\BackupsController` There is therefore **no working UI path to clear a stuck backup**. ### Root cause `BackupsController::cancelStalled()` and `purge()` fetch the DB via `$this->app->getContainer()`, but `CMSApplication::getContainer()` is `protected`. ### Fix Use `Factory::getContainer()` (as the rest of the component already does). Both call sites corrected on branch `fix/backup-cancel-stall-runbackup-updatesite`. ### Repro 1. Have a backup record in `running` state. 2. Backup Records → select it → **Cancel Stalled** → fatal.
jmiller commented 2026-07-18 20:36:07 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/306-cancel-stalled-throws-a-fatal-error-prot

git fetch origin
git checkout feature/306-cancel-stalled-throws-a-fatal-error-prot
Branch created: [`feature/306-cancel-stalled-throws-a-fatal-error-prot`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/306-cancel-stalled-throws-a-fatal-error-prot) ```bash git fetch origin git checkout feature/306-cancel-stalled-throws-a-fatal-error-prot ```
Sign in to join this conversation.
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?