fix: pre-action backup fires for every extension (not one per 10 min) #250

2026-07-12T22:48:28Z

jmiller commented

2026-07-12 22:48:28 +00:00

Replaces the 600s pre-action throttle (which suppressed all extension backups for 10 min after any one ran) with one-backup-per-Update-action: per-request dedupe + a one-shot action-keyed skip flag; core update decoupled to its own key.

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Replaces the 600s pre-action throttle (which suppressed all extension backups for 10 min after any one ran) with one-backup-per-Update-action: per-request dedupe + a one-shot action-keyed skip flag; core update decoupled to its own key. https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

jmiller added 2 commits 2026-07-12 22:48:29 +00:00

@

Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 18s

Details

3eb2562abd

fix: pre-action backup fires for every extension, not one per 10 min

Root cause of "pre-update backup only fires on the backup extension":
a coarse 600s session throttle. Whenever ANY pre-action backup ran
(including updating MokoSuiteBackup itself, or a core Joomla update), the
key mokosuitebackup.preaction_backup_before_update was armed for 10
minutes. onBeforeCompileHead read it as `recentBackup` and DISABLED the
client-side interceptor for all extensions, and runPreActionBackup was
throttled by the same window. So after updating one extension, every
other extension update silently skipped its backup for 10 minutes.

Replace the time window with "one backup per Update action":
- runPreActionBackup dedupes per-request (a batch update fires the event
  once per extension in a single request -> back up once) via instance
  flags, and consumes a ONE-SHOT session skip flag for the re-fired
  client update/uninstall (skip once, next distinct action backs up).
- ajax.preupdateAck sets the one-shot flag for the SPECIFIC action
  (update|uninstall), passed from installer-backup.js via &msb_action and
  surfaced by Runbackup HtmlView -> CFG.action. A core update passes no
  action, so it never suppresses an extension backup.
- onBeforeCompileHead drops the recentBackup time-suppression (the
  re-fire loop is already guarded client-side by window.__msbResuming).
- The core Joomla update path uses its own key
  (mokosuitebackup.core_update_backed_up), decoupled from extensions.

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
@

chore(version): pre-release bump to 02.59.01-dev [skip ci]

Branch Cleanup / Delete merged branch (pull_request) Has been cancelled

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been cancelled

Details

2df4b280eb

jmiller added 1 commit 2026-07-12 22:48:29 +00:00

chore(version): pre-release bump to 02.59.01-dev [skip ci]

Branch Cleanup / Delete merged branch (pull_request) Has been cancelled

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been cancelled

Details

2df4b280eb

jmiller merged commit f02c4d4c9d into dev

2026-07-12 22:48:33 +00:00

jmiller deleted branch fix/preaction-per-action-backup

2026-07-12 22:48:34 +00:00

Sign in to join this conversation.

Priority -

Type -

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#250