fix(engine): check + log restore-script remote upload (fixes #226) #227

2026-07-06T00:40:00Z

jmiller commented

2026-07-06 00:40:00 +00:00

Fixes #226 (restore script silently missing from the remote).

The standalone restore-script upload discarded its result and logged nothing, so a failed second upload() left the script off the remote with no warning — the archive still recorded complete.

Now: log the restore-script upload attempt, log success, and on failure set $uploadFailed = true (→ warning status) and log the reason. So it can never be silent again, and the backup surfaces a warning if the script didn't make it.

Targeting dev for a dev build. php -l clean.

Note: this makes the failure visible; if the underlying cause is that a given uploader can't do a second upload() on the same connection, the warning will now tell us which destination — a follow-up can re-open the connection per file if needed.

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Fixes #226 (restore script silently missing from the remote). The standalone restore-script upload discarded its result and logged nothing, so a failed second `upload()` left the script off the remote with **no warning** — the archive still recorded `complete`. Now: log the restore-script upload attempt, log success, and on failure set `$uploadFailed = true` (→ `warning` status) and log the reason. So it can never be silent again, and the backup surfaces a warning if the script didn't make it. Targeting **dev** for a dev build. `php -l` clean. Note: this makes the failure **visible**; if the underlying cause is that a given uploader can't do a second `upload()` on the same connection, the warning will now tell us which destination — a follow-up can re-open the connection per file if needed. https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

jmiller added 2 commits 2026-07-06 00:40:01 +00:00

fix(engine): check + log restore-script remote upload (no longer silent)

Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 21s

Details

bf91611b97

The standalone restore script was uploaded to each remote with the result
discarded and nothing logged, so a failed second upload left the restore script
missing from the remote with no warning while the archive still recorded
'complete'. Capture the result: log success, and on failure set uploadFailed
(-> warning status) and log the reason.

Fixes #226

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

chore(version): pre-release bump to 02.58.02-dev [skip ci]

Branch Cleanup / Delete merged branch (pull_request) Successful in 1s

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped

Details

35febb8854

jmiller merged commit 2cb8527c25 into dev

2026-07-06 00:40:18 +00:00

jmiller deleted branch fix/restore-script-upload-result

2026-07-06 00:40:19 +00:00

jmiller referenced this pull request

2026-07-06 01:17:12 +00:00