fix: use warning status when backup succeeds but upload fails #199

Merged

jmiller merged 4 commits from fix/upload-fail-warning-status into main 2026-06-30 19:18:07 +00:00

Conversation 0 Commits 4 Files Changed 33

+58 -35

jmiller commented 2026-06-30 19:14:40 +00:00

Owner

Copy Link

Copy Source

Summary

• Backups where the archive was created successfully but remote upload failed were previously marked as complete, hiding the upload failure
• Now these get a warning status with a yellow badge so operators can immediately see which backups didn't reach their remote destination
• Warning-status records are fully usable: downloadable, browsable, restorable, purgeable
• Updated across 18 files: both backup engines, both restore engines, dashboard model, status helper, controllers, templates, filter dropdown, cpanel module, language files, and SQL schema comment

Changed files

• BackupEngine / SteppedBackupEngine: set warning instead of complete when $uploadFailed is true
• RestoreEngine / SteppedRestoreEngine: accept warning records for restore
• AjaxController: browseArchive and countPurge accept warning
• BackupsController: purge includes warning records
• DashboardModel: last backup, stats, and profile breakdown include warning
• BackupStatusHelper: latest record and streak count include warning
• PreflightCheck: disk space estimation uses warning backups
• BackupEngine: differential base lookup includes warning
• Templates: yellow bg-warning text-dark badge in list, detail, and cpanel module
• filter_backups.xml: warning option in status dropdown
• Language files: COM_MOKOJOOMBACKUP_STATUS_WARNING and MOD_MOKOSUITEBACKUP_CPANEL_STATUS_WARNING

Test plan

• Trigger a backup with a misconfigured remote — record should show yellow "warning" badge
• Verify warning record is downloadable, browsable, and restorable
• Filter by "Warning" status in Backup Records dropdown
• Dashboard "Last Backup" card shows warning records
• Purge includes warning records
• CPanel module shows yellow badge for warning status

https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

## Summary - Backups where the archive was created successfully but remote upload failed were previously marked as `complete`, hiding the upload failure - Now these get a `warning` status with a yellow badge so operators can immediately see which backups didn't reach their remote destination - Warning-status records are fully usable: downloadable, browsable, restorable, purgeable - Updated across 18 files: both backup engines, both restore engines, dashboard model, status helper, controllers, templates, filter dropdown, cpanel module, language files, and SQL schema comment ## Changed files - **BackupEngine** / **SteppedBackupEngine**: set `warning` instead of `complete` when `$uploadFailed` is true - **RestoreEngine** / **SteppedRestoreEngine**: accept `warning` records for restore - **AjaxController**: `browseArchive` and `countPurge` accept `warning` - **BackupsController**: purge includes `warning` records - **DashboardModel**: last backup, stats, and profile breakdown include `warning` - **BackupStatusHelper**: latest record and streak count include `warning` - **PreflightCheck**: disk space estimation uses `warning` backups - **BackupEngine**: differential base lookup includes `warning` - **Templates**: yellow `bg-warning text-dark` badge in list, detail, and cpanel module - **filter_backups.xml**: `warning` option in status dropdown - **Language files**: `COM_MOKOJOOMBACKUP_STATUS_WARNING` and `MOD_MOKOSUITEBACKUP_CPANEL_STATUS_WARNING` ## Test plan - [ ] Trigger a backup with a misconfigured remote — record should show yellow "warning" badge - [ ] Verify warning record is downloadable, browsable, and restorable - [ ] Filter by "Warning" status in Backup Records dropdown - [ ] Dashboard "Last Backup" card shows warning records - [ ] Purge includes warning records - [ ] CPanel module shows yellow badge for warning status https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

jmiller added 2 commits 2026-06-30 19:14:41 +00:00

fix: use warning status when backup succeeds but remote upload fails ... aefa46e0c4

Previously a successful backup with a failed remote upload was marked
as "complete", hiding the upload failure. Now these records get a
"warning" status with a yellow badge so operators can see at a glance
which backups didn't reach their remote destination.

Warning-status records are treated as usable backups throughout:
- Downloadable, browsable, and restorable (the archive is intact)
- Counted in dashboard stats, storage totals, and success streaks
- Included in purge operations and differential base lookups
- Shown with yellow "warning" badge in list, detail, and cpanel module
- Filterable via the status dropdown on Backup Records

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

chore(version): pre-release bump to 02.52.23-dev [skip ci] 1daa6869cc

jmiller added 1 commit 2026-06-30 19:17:38 +00:00

docs: add warning status changes to changelog ... 9c0c6eae15

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

jmiller added 1 commit 2026-06-30 19:17:59 +00:00

chore(version): pre-release bump to 02.52.24-dev [skip ci] 9820d75212

jmiller merged commit 7b38e238f5 into main 2026-06-30 19:18:07 +00:00

jmiller deleted branch fix/upload-fail-warning-status 2026-06-30 19:18:08 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#199