fix: cancel stalled backups with ACL + auto-timeout failsafe #197

Merged

jmiller merged 6 commits from fix/cancel-stalled-backup into main 2026-06-30 18:53:16 +00:00

Conversation 0 Commits 6 Files Changed 24

+221 -21

jmiller commented 2026-06-30 18:50:35 +00:00

Owner

Copy Link

Copy Source

Summary

• Backups stuck in "running" status permanently block future backups for the same profile via preflight check — previously required manual DB update to fix
• Adds Cancel Stalled toolbar button on Backup Records view (checkbox multi-select) with new ACL permission mokosuitebackup.backup.cancel
• Adds ajax.cancelBackup AJAX endpoint for programmatic/API use
• Auto-timeout failsafe: PreflightCheck now auto-cancels "running" records older than 30 minutes, cleaning up partial archives and surfacing warnings — stalled backups can never permanently block scheduled/CLI runs
• Updated preflight error message to guide users to the Cancel Stalled action

Test plan

• Select a backup with "running" status, click Cancel Stalled — should change to "fail" and delete partial archive
• Selecting non-running records shows "none in running status" warning
• Verify ACL: users without mokosuitebackup.backup.cancel don't see the button
• Verify auto-timeout: create a running record older than 30 min, trigger a new backup — stale record auto-cancels with warning
• Verify a legitimately running backup (<30 min) still blocks new backups

https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

## Summary - Backups stuck in "running" status permanently block future backups for the same profile via preflight check — previously required manual DB update to fix - Adds **Cancel Stalled** toolbar button on Backup Records view (checkbox multi-select) with new ACL permission `mokosuitebackup.backup.cancel` - Adds `ajax.cancelBackup` AJAX endpoint for programmatic/API use - **Auto-timeout failsafe**: PreflightCheck now auto-cancels "running" records older than 30 minutes, cleaning up partial archives and surfacing warnings — stalled backups can never permanently block scheduled/CLI runs - Updated preflight error message to guide users to the Cancel Stalled action ## Test plan - [ ] Select a backup with "running" status, click Cancel Stalled — should change to "fail" and delete partial archive - [ ] Selecting non-running records shows "none in running status" warning - [ ] Verify ACL: users without `mokosuitebackup.backup.cancel` don't see the button - [ ] Verify auto-timeout: create a running record older than 30 min, trigger a new backup — stale record auto-cancels with warning - [ ] Verify a legitimately running backup (<30 min) still blocks new backups https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

jmiller added 3 commits 2026-06-30 18:50:35 +00:00

fix: add cancel stalled backup action with ACL permission ... 1eb1c18bdf

Backups stuck in "running" status block all future backups for the same
profile via the preflight check. Previously the only fix was a manual
DB update.

Adds a toolbar button and AJAX endpoint to cancel stalled backups:
- New ACL permission: mokosuitebackup.backup.cancel
- BackupsController::cancelStalled() for toolbar (multi-select)
- AjaxController::cancelBackup() for AJAX/API use
- Sets status to "fail", cleans up partial archive files
- Updated preflight error message to mention the cancel action
- Language keys for en-GB and en-US

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

chore(version): pre-release bump to 02.52.20-dev [skip ci] a56f72b186

fix: auto-cancel stalled backups after 30 min timeout ... b26a21820b

PreflightCheck now auto-cancels "running" backup records that have
exceeded 30 minutes, treating them as stalled. Partial archive files
are cleaned up. The auto-cancelled records are surfaced as warnings
so the user knows what happened.

Records younger than 30 minutes are assumed to be legitimately running
and still block new backups for the same profile.

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

jmiller added 1 commit 2026-06-30 18:50:42 +00:00

chore(version): pre-release bump to 02.52.21-dev [skip ci] 5be922613f

jmiller referenced this pull request 2026-06-30 18:51:08 +00:00

feat: backup queue system for concurrent backup conflicts #198

jmiller added 1 commit 2026-06-30 18:52:48 +00:00

docs: update changelog with cancel stalled and pre-update modal ... 4560ffb84b

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

jmiller added 1 commit 2026-06-30 18:53:08 +00:00

chore(version): pre-release bump to 02.52.22-dev [skip ci] 8dac5a7448

jmiller merged commit 1db4015003 into main 2026-06-30 18:53:16 +00:00

jmiller deleted branch fix/cancel-stalled-backup 2026-06-30 18:53:17 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#197