MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 3 Pull Requests Packages Releases 2 Wiki Activity

fix: Resolve [site_name] and all placeholders in checkDir AJAX #126

Merged
jmiller merged 2 commits from fix/site-name-resolution into main 2026-06-23 16:50:09 +00:00
Conversation 0 Commits 2 Files Changed 15
+1351 -1324
jmiller commented 2026-06-23 16:49:42 +00:00
Owner
Copy Link
Copy Source

The checkDir AJAX endpoint only resolved [HOME] and [DEFAULT_DIR] via BackupDirectory::resolve(). Placeholders like [site_name], [host], [profile_id] were left as literal text, causing the status to show "Uses placeholders" and the resolved path to contain unresolved tokens.

Now uses PlaceholderResolver to resolve all placeholders before checking directory existence. If a profile_id is passed in the request, uses that profile for accurate resolution.

The checkDir AJAX endpoint only resolved [HOME] and [DEFAULT_DIR] via BackupDirectory::resolve(). Placeholders like [site_name], [host], [profile_id] were left as literal text, causing the status to show "Uses placeholders" and the resolved path to contain unresolved tokens. Now uses PlaceholderResolver to resolve all placeholders before checking directory existence. If a profile_id is passed in the request, uses that profile for accurate resolution.
jmiller added the component: admin label 2026-06-23 16:49:42 +00:00
jmiller added 1 commit 2026-06-23 16:49:42 +00:00
fix: resolve [site_name] and other placeholders in checkDir AJAX
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Blocked by required conditions
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 2s
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 5s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 3s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 15s
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 8s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 7s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Details
Universal: Build & Release / Promote to RC (pull_request) Failing after 15s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 46s
Details
e415e701cd 
BackupDirectory::resolve() only handles [HOME] and [DEFAULT_DIR].
The checkDir AJAX endpoint now uses PlaceholderResolver to also
resolve [site_name], [host], [profile_id], [date], etc. before
checking if the directory exists. This makes the "Resolves to"
display accurate for all placeholder types.
jmiller added 1 commit 2026-06-23 16:49:47 +00:00
chore(version): pre-release bump to 01.38.03-dev [skip ci]
Publish to Composer / Publish Package (release) Failing after 7s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 6s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 21s
Details
cbff40d04c
jmiller merged commit 747b68c179 into main 2026-06-23 16:50:09 +00:00
jmiller deleted branch fix/site-name-resolution 2026-06-23 16:50:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
No labels component: admin
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#126
Delete Branch "fix/site-name-resolution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?