From eeb29eb751ac0d06ac93cb7331c0cb8b2c77555d Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Fri, 26 Jun 2026 21:15:22 -0500 Subject: [PATCH] fix: remove duplicate version tags from 8 manifests, align AjaxController to params column CI version_bump was creating duplicate lines in all sub-extension manifests. Also AjaxController still referenced the old `config` column and removed `keep_local` column on the remotes table. Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG --- .../src/Controller/AjaxController.php | 14 +++++--------- .../mod_mokosuitebackup_cpanel.xml | 1 - .../mokosuitebackup.xml | 1 - .../mokosuitebackup.xml | 1 - .../mokosuitebackup.xml | 1 - .../mokosuitebackup.xml | 1 - .../plg_system_mokosuitebackup/mokosuitebackup.xml | 1 - .../plg_task_mokosuitebackup/mokosuitebackup.xml | 1 - .../mokosuitebackup.xml | 1 - 9 files changed, 5 insertions(+), 17 deletions(-) diff --git a/source/packages/com_mokosuitebackup/src/Controller/AjaxController.php b/source/packages/com_mokosuitebackup/src/Controller/AjaxController.php index 41c861a..159af3b 100644 --- a/source/packages/com_mokosuitebackup/src/Controller/AjaxController.php +++ b/source/packages/com_mokosuitebackup/src/Controller/AjaxController.php @@ -924,11 +924,11 @@ class AjaxController extends BaseController return; } - // Decode JSON config and mask secrets + // Decode JSON params and mask secrets $items = []; foreach ($rows as $row) { - $config = json_decode($row->config, true) ?: []; + $config = json_decode($row->params, true) ?: []; // Mask sensitive fields so they never leave the server in list views $masked = $this->maskSecrets($config, $row->type); @@ -939,8 +939,7 @@ class AjaxController extends BaseController 'title' => $row->title, 'type' => $row->type, 'enabled' => (int) $row->enabled, - 'keep_local' => (int) $row->keep_local, - 'config' => $masked, + 'params' => $masked, 'ordering' => (int) $row->ordering, ]; } @@ -971,7 +970,6 @@ class AjaxController extends BaseController $title = trim($this->input->getString('remote_title', '')); $type = $this->input->getCmd('remote_type', 'sftp'); $enabled = $this->input->getInt('remote_enabled', 1); - $keepLocal = $this->input->getInt('remote_keep_local', 1); $configRaw = $this->input->getString('remote_config', '{}'); if (!$profileId) { @@ -1019,9 +1017,7 @@ class AjaxController extends BaseController $table->title = $title; $table->type = $type; $table->enabled = $enabled ? 1 : 0; - $table->keep_local = $keepLocal ? 1 : 0; - $table->config = json_encode($config); - + $table->params = json_encode($config); if (!$table->check() || !$table->store()) { $this->sendJson(['error' => true, 'message' => $table->getError() ?: 'Save failed']); @@ -1190,7 +1186,7 @@ class AjaxController extends BaseController try { $db = Factory::getDbo(); $query = $db->getQuery(true) - ->select($db->quoteName('config')) + ->select($db->quoteName('params')) ->from($db->quoteName('#__mokosuitebackup_remotes')) ->where($db->quoteName('id') . ' = ' . $id); $db->setQuery($query); diff --git a/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml b/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml index 1a493e8..dfd2640 100644 --- a/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml +++ b/source/packages/mod_mokosuitebackup_cpanel/mod_mokosuitebackup_cpanel.xml @@ -9,7 +9,6 @@ mod_mokosuitebackup_cpanel 01.43.26 - 01.43.26 2026-06-23 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml index f9204ac..b4b7bee 100644 --- a/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ Action Log - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-04 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml index af2807d..0afd5c5 100644 --- a/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ Console - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-04 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml index 3056e50..3fae853 100644 --- a/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ Content - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-04 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml index b31779e..6a54105 100644 --- a/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml @@ -2,7 +2,6 @@ Quick Icon - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-02 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml index 8a25091..f8593ce 100644 --- a/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ System - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-02 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml index d0ace9d..7771324 100644 --- a/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ Task - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-02 Moko Consulting hello@mokoconsulting.tech diff --git a/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml b/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml index cb71a02..de00043 100644 --- a/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml +++ b/source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml @@ -8,7 +8,6 @@ Web Services - MokoSuiteBackup 01.43.26 - 01.43.26 2026-06-02 Moko Consulting hello@mokoconsulting.tech