fix: address final review — garbled code, error handling, write checks

Critical: - Fix garbled getDbConnection() in MokoRestore — duplicated lines and broken regex causing parse errors in the standalone restore script High: - fixPackageClientId() now warns user via enqueueMessage on failure - sanitizeConfiguration() logs error when file read fails - actionConfig() checks file_put_contents return value on both paths - writeDefaultHtaccess() returns status string, checks copy and write, callers append warnings to response message Medium: - Remove @unlink suppression before archive rename, log warning - viewLog() catch block now logs exception message for diagnostics
2026-06-15 00:49:24 -05:00
parent a6de692639
commit b0fa2cceba
4 changed files with 49 additions and 16 deletions
@@ -495,6 +495,12 @@ class Pkg_MokoSuiteBackupInstallerScript
 			$db->execute();
 		} catch (\Exception $e) {
 			error_log('MokoSuiteBackup: fixPackageClientId() failed: ' . $e->getMessage());
+			Factory::getApplication()->enqueueMessage(
+				'MokoSuiteBackup could not correct the package registration. '
+				. 'Automatic updates may not appear. If you do not see update notifications, '
+				. 'please reinstall the package.',
+				'warning'
+			);
 		}
 	}