feat: add granular ACL permissions via access.xml

Add access.xml with standard Joomla core actions (admin, options, manage, create, delete, edit, edit.state) plus three custom actions for backup-specific operations: - mokosuitebackup.backup.run — trigger backup operations - mokosuitebackup.backup.download — download archive files (contains full database and site files) - mokosuitebackup.backup.restore — restore from backup (destructive) Also includes: remaining review fixes for enqueueMessage consistency in ensureSubmenuItems, syncMenuIcons, warnMissingLicenseKey catch blocks, and index.html write check in createBackupDirectory.
2026-06-13 07:09:16 -05:00
parent 79a476c7fc
commit 7071b92a19
7 changed files with 67 additions and 1 deletions
@@ -231,7 +231,9 @@ class Pkg_MokoSuiteBackupInstallerScript
 		$indexHtml = $backupDir . '/index.html';

 		if (!file_exists($indexHtml)) {
-			file_put_contents($indexHtml, '<!DOCTYPE html><title></title>');
+			if (file_put_contents($indexHtml, '<!DOCTYPE html><title></title>') === false) {
+				error_log('MokoSuiteBackup: Failed to write index.html to ' . $backupDir);
+			}
 		}
 	}

@@ -468,6 +470,11 @@ class Pkg_MokoSuiteBackupInstallerScript
 			}
 		} catch (\Exception $e) {
 			error_log('MokoSuiteBackup: ensureSubmenuItems() failed: ' . $e->getMessage());
+			Factory::getApplication()->enqueueMessage(
+				'MokoSuiteBackup could not create or update sidebar menu items. '
+				. 'If submenu entries are missing, try reinstalling the component.',
+				'warning'
+			);
 		}
 	}

@@ -502,6 +509,10 @@ class Pkg_MokoSuiteBackupInstallerScript
 			$db->execute();
 		} catch (\Exception $e) {
 			error_log('MokoSuiteBackup: syncMenuIcons() failed: ' . $e->getMessage());
+			Factory::getApplication()->enqueueMessage(
+				'MokoSuiteBackup could not update sidebar menu icons. This is cosmetic and does not affect functionality.',
+				'notice'
+			);
 		}
 	}

@@ -583,6 +594,11 @@ class Pkg_MokoSuiteBackupInstallerScript
 		}
 		catch (\Exception $e) {
 			error_log('MokoSuiteBackup: License key check failed: ' . $e->getMessage());
+			Factory::getApplication()->enqueueMessage(
+				'MokoSuiteBackup could not verify your license key status. '
+				. 'Please check System &rarr; Update Sites to ensure a valid license key is configured.',
+				'warning'
+			);
 		}
 	}
 }