From fa8baf4df14a58da96cf7f4f7868a0af80809f27 Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Sun, 21 Jun 2026 17:57:57 -0500 Subject: [PATCH] =?UTF-8?q?fix:=20review=20#19=20=E2=80=94=20DealHelper=20?= =?UTF-8?q?trade=20allowance=20in=20gross=20profit,=20FinancingHelper=20ne?= =?UTF-8?q?gative=20equity=20rollover?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../plg_system_mokosuiteauto/src/Helper/DealHelper.php | 3 ++- .../plg_system_mokosuiteauto/src/Helper/FinancingHelper.php | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/source/packages/plg_system_mokosuiteauto/src/Helper/DealHelper.php b/source/packages/plg_system_mokosuiteauto/src/Helper/DealHelper.php index 8cc0d92..4c57a08 100644 --- a/source/packages/plg_system_mokosuiteauto/src/Helper/DealHelper.php +++ b/source/packages/plg_system_mokosuiteauto/src/Helper/DealHelper.php @@ -57,7 +57,8 @@ class DealHelper } $frontGross = (float) $deal->sale_price - (float) $deal->invoice_price - - (float) ($deal->reconditioning_cost ?? 0); + - (float) ($deal->reconditioning_cost ?? 0) + - (float) ($deal->trade_allowance ?? 0); // F&I back-end gross $db->setQuery($db->getQuery(true) diff --git a/source/packages/plg_system_mokosuiteauto/src/Helper/FinancingHelper.php b/source/packages/plg_system_mokosuiteauto/src/Helper/FinancingHelper.php index 4d689e0..8967e49 100644 --- a/source/packages/plg_system_mokosuiteauto/src/Helper/FinancingHelper.php +++ b/source/packages/plg_system_mokosuiteauto/src/Helper/FinancingHelper.php @@ -79,7 +79,8 @@ class FinancingHelper } $tradeEquity = (float) $deal->trade_value - (float) $deal->payoff; - $effectivePrice = (float) $deal->sale_price - max(0, $tradeEquity); + // Negative equity rolls into financed amount (customer owes more than trade value) + $effectivePrice = (float) $deal->sale_price - $tradeEquity; $scenarios = []; $rates = [3.9, 5.9, 7.9];