MokoConsulting/MokoOnyx
1
0
Fork 0
Code Issues 10 Pull Requests Releases 5 Wiki Activity

fix(menu): remove hardcoded p-2 padding from menu icon spans
Joomla: Repo Health / Access control (push) Successful in 1s
Details
Joomla: Repo Health / Release configuration (push) Failing after 3s
Details
Joomla: Repo Health / Scripts governance (push) Successful in 2s
Details
Joomla: Repo Health / Repository health (push) Failing after 3s
Details

Browse Source 
The menu override templates were adding Bootstrap p-2 (padding) class
to all menu icon spans, causing unwanted spacing around Font Awesome
icons in navigation items. Icons should inherit their spacing from
the surrounding link element, not add their own padding.

Affected files: all mod_menu layout overrides (mainmenu_*, horizontal_*)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jonathan Miller
2026-05-16 14:33:55 -05:00
parent d4f2432332
commit 7b52a06cc1
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/html/mod_menu/mainmenu_component.php
+2 -2
View File
@@ -36,10 +36,10 @@ if ($item->menu_icon) {
// The link is an icon
if ($itemParams->get('menu_text', 1)) {
// If the link text is to be displayed, the icon is added with aria-hidden
$linktype = '<span class="p-2 ' . $item->menu_icon . '" aria-hidden="true"></span>' . $item->title;
$linktype = '<span class="' . $item->menu_icon . '" aria-hidden="true"></span>' . $item->title;
} else {
// If the icon itself is the link, it needs a visually hidden text
$linktype = '<span class="p-2 ' . $item->menu_icon . '" aria-hidden="true"></span><span class="visually-hidden">' . $item->title . '</span>';
$linktype = '<span class="' . $item->menu_icon . '" aria-hidden="true"></span><span class="visually-hidden">' . $item->title . '</span>';
}
}