MokoConsulting/MokoJoomCross
1
0
Fork 0
Code Issues 97 Pull Requests Releases 1 Wiki Activity

Fixed: ServiceTable missing check() method #87

New Issue
Closed
opened 2026-05-29 05:30:25 +00:00 by jmiller · 1 comment
jmiller commented 2026-05-29 05:30:25 +00:00
Owner
Copy Link
Copy Source

Fixed in commit 8dd6fdd

Severity: High

What was wrong:
No input validation on save. Alias never generated from title. No defaults for timestamps, created_by, or JSON columns.

Fix applied:
Added check() with alias generation via OutputFilter::stringURLSafe(), required field validation for title and service_type, timestamp management, created_by default, and JSON defaults for credentials/params.

Files: ServiceTable.php

Label: priority: high, status: pending-testing

## Fixed in commit 8dd6fdd **Severity:** High **What was wrong:** No input validation on save. Alias never generated from title. No defaults for timestamps, created_by, or JSON columns. **Fix applied:** Added `check()` with alias generation via `OutputFilter::stringURLSafe()`, required field validation for title and service_type, timestamp management, created_by default, and JSON defaults for credentials/params. **Files:** `ServiceTable.php` **Label:** `priority: high`, `status: pending-testing`
jmiller commented 2026-05-29 05:30:26 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/87-fixed-servicetable-missing-check-method

git fetch origin
git checkout feature/87-fixed-servicetable-missing-check-method
Branch created: [`feature/87-fixed-servicetable-missing-check-method`](https://git.mokoconsulting.tech/MokoConsulting/MokoJoomCross/src/branch/feature/87-fixed-servicetable-missing-check-method) ```bash git fetch origin git checkout feature/87-fixed-servicetable-missing-check-method ```
Sign in to join this conversation.
Labels
Clear labels
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels
Type Bug
Status —
Priority —
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoJoomCross#87
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?