From 6be3e5c879522a7b211bf0747598f9b345279bbe Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Thu, 4 Jun 2026 16:28:14 -0500 Subject: [PATCH] fix(updateserver): always show downloadkey when licensing enabled Include in Joomla update XML whenever Update Server is enabled for the repo, not just when require_key is set. This ensures Joomla shows the Download Key field in Update Sites even when downloads are currently public. Also corrected joomlaTagName comment with Joomla source reference. Co-Authored-By: Claude Opus 4.6 (1M context) --- routers/web/repo/updateserver.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/routers/web/repo/updateserver.go b/routers/web/repo/updateserver.go index 59f6a14203..29a6b77355 100644 --- a/routers/web/repo/updateserver.go +++ b/routers/web/repo/updateserver.go @@ -94,7 +94,9 @@ func ServeUpdatesXML(ctx *context.Context) { } repoCfg, _ := licenses.GetRepoConfig(ctx, ctx.Repo.Repository.ID) - requireKey := repoCfg != nil && repoCfg.RequireKey + // Show when licensing is enabled (prepares Joomla to accept keys) + // or when require_key is explicitly set. + requireKey := repoCfg != nil && (repoCfg.LicensingEnabled || repoCfg.RequireKey) xmlData, err := updateserver.GenerateJoomlaXML(ctx, ctx.Repo.Repository, requireKey, stripDownloads, allowedChannels...) if err != nil { -- 2.52.0