From c90edc3efce36bd0c10b8739b80c9f27dd630ebc Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Thu, 4 Jun 2026 07:50:41 -0500 Subject: [PATCH] fix(settings): prevent double-highlight on Advanced Settings nav item SettingsCtxData middleware sets PageIsSettingsOptions=true for all settings routes including /advanced. The advanced handler now explicitly clears it so only the Advanced Settings nav item is highlighted. Co-Authored-By: Claude Opus 4.6 (1M context) --- routers/web/repo/setting/advanced.go | 1 + 1 file changed, 1 insertion(+) diff --git a/routers/web/repo/setting/advanced.go b/routers/web/repo/setting/advanced.go index fbebe39bb1..609a6dd42b 100644 --- a/routers/web/repo/setting/advanced.go +++ b/routers/web/repo/setting/advanced.go @@ -15,6 +15,7 @@ const tplSettingsAdvanced templates.TplName = "repo/settings/advanced" // AdvancedSettings displays the advanced (feature units) settings page. func AdvancedSettings(ctx *context.Context) { ctx.Data["Title"] = ctx.Tr("repo.settings.advanced_settings") + ctx.Data["PageIsSettingsOptions"] = false ctx.Data["PageIsSettingsAdvanced"] = true ctx.HTML(http.StatusOK, tplSettingsAdvanced) } -- 2.52.0