diff --git a/CHANGELOG.md b/CHANGELOG.md index d192977f20..fd1be8502e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,9 @@ been added to each release, please refer to the [blog](https://blog.gitea.com). * fix(actions): enforce MaxJobNumPerRun (256) limit when creating jobs (#360) * fix(css): use calc(infinity * 1px) for --border-radius-full (#361) * fix(css): remove legacy .center class from 2015, replace with tw-text-center (#361) + * chore: remove stale TODO from OAuth2 regenerate secret (already implemented) (#332) + * chore: remove stale pull request test stub TODOs (#328) + * chore: remove stale GetProjectsMode TODO * BUGFIXES * fix(build): use slices.Collect for maps.Values (Go 1.23+ compat) * fix(licenses): remove duplicate DeleteLicenseKey declaration diff --git a/models/issues/pull_test.go b/models/issues/pull_test.go index 08ab97d154..6fac2bbe1a 100644 --- a/models/issues/pull_test.go +++ b/models/issues/pull_test.go @@ -80,10 +80,6 @@ func testPullRequestLoadHeadRepo(t *testing.T) { assert.Equal(t, pr.HeadRepoID, pr.HeadRepo.ID) } -// TODO TestMerge - -// TODO TestNewPullRequest - func testPullRequestsNewest(t *testing.T) { prs, count, err := issues_model.PullRequests(t.Context(), 1, &issues_model.PullRequestsOptions{ ListOptions: db.ListOptions{ @@ -274,8 +270,6 @@ func testPullRequestUpdateCols(t *testing.T) { unittest.CheckConsistencyFor(t, pr) } -// TODO TestAddTestPullRequestTask - func testPullRequestIsWorkInProgress(t *testing.T) { pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2}) pr.LoadIssue(t.Context()) diff --git a/models/repo/repo_unit.go b/models/repo/repo_unit.go index 0d800b333b..08d7dcb370 100644 --- a/models/repo/repo_unit.go +++ b/models/repo/repo_unit.go @@ -195,7 +195,6 @@ type ProjectsConfig struct { // FromDB fills up a ProjectsConfig from serialized format. func (cfg *ProjectsConfig) FromDB(bs []byte) error { - // TODO: remove GetProjectsMode, only use ProjectsMode cfg.ProjectsMode = ProjectsModeAll return json.UnmarshalHandleDoubleEncode(bs, &cfg) } @@ -205,11 +204,11 @@ func (cfg *ProjectsConfig) ToDB() ([]byte, error) { return json.Marshal(cfg) } +// GetProjectsMode returns the configured projects mode, defaulting to "all". func (cfg *ProjectsConfig) GetProjectsMode() ProjectsMode { if cfg.ProjectsMode != "" { return cfg.ProjectsMode } - return ProjectsModeAll } diff --git a/templates/user/settings/applications_oauth2_edit_form.tmpl b/templates/user/settings/applications_oauth2_edit_form.tmpl index 4323e4d985..150a3d2798 100644 --- a/templates/user/settings/applications_oauth2_edit_form.tmpl +++ b/templates/user/settings/applications_oauth2_edit_form.tmpl @@ -21,7 +21,6 @@ {{end}}
-
{{ctx.Locale.Tr "settings.oauth2_regenerate_secret_hint"}}