MokoConsulting/MokoGitea
1
0
Fork 0
Code Issues 142 Pull Requests Releases 90 Wiki Activity

feat(licenses): add archive/soft-delete for license packages #384

New Issue
Closed
opened 2026-06-01 09:18:14 +00:00 by jmiller · 2 comments
jmiller commented 2026-06-01 09:18:14 +00:00
Owner
Copy Link
Copy Source

Summary

Add an IsArchived field to LicensePackage so packages can be archived instead of permanently deleted. Archived packages are hidden from the main list but preserved for audit trails and existing key references.

Requirements

  • Add IsArchived bool field to LicensePackage model
  • Migration to add the column
  • Archive button in template (replaces delete for non-admins)
  • Archived packages hidden from default list, shown in a collapsible "Archived" section
  • Archived packages cannot generate new keys
  • Existing keys from archived packages continue to work
  • Site admins and org owners can permanently delete archived packages

Test Plan

  • Archive a package ? verify hidden from main list
  • Check archived section ? verify package appears there
  • Try to generate key from archived package ? verify rejected
  • Verify existing keys from archived package still validate
  • Unarchive ? verify returns to main list
  • Permanently delete archived package as site admin ? verify removed
  • Permanently delete as org owner ? verify removed
  • Try permanent delete as non-owner ? verify rejected

?? Generated with Claude Code

## Summary Add an `IsArchived` field to `LicensePackage` so packages can be archived instead of permanently deleted. Archived packages are hidden from the main list but preserved for audit trails and existing key references. ## Requirements - Add `IsArchived bool` field to `LicensePackage` model - Migration to add the column - Archive button in template (replaces delete for non-admins) - Archived packages hidden from default list, shown in a collapsible "Archived" section - Archived packages cannot generate new keys - Existing keys from archived packages continue to work - Site admins and org owners can permanently delete archived packages ## Test Plan - [ ] Archive a package ? verify hidden from main list - [ ] Check archived section ? verify package appears there - [ ] Try to generate key from archived package ? verify rejected - [ ] Verify existing keys from archived package still validate - [ ] Unarchive ? verify returns to main list - [ ] Permanently delete archived package as site admin ? verify removed - [ ] Permanently delete as org owner ? verify removed - [ ] Try permanent delete as non-owner ? verify rejected ?? Generated with [Claude Code](https://claude.com/claude-code)
jmiller commented 2026-06-01 10:10:41 +00:00
Author
Owner
Copy Link
Copy Source

Testing Plan — Package Archive

API

  • Archive package via POST → verify hidden from list endpoint
  • Archived package keys still validate via POST /validate
  • Unarchive package → verify returns to list
  • Generate key from archived package → verify rejected

GUI

  • Archive button (orange) visible on non-master packages
  • Collapsible "Archived Packages" section appears with count
  • Unarchive (reply icon) restores to main list
  • Delete button only for owners in archived section
  • Archive modal confirmation appears

🤖 Generated with Claude Code

## Testing Plan — Package Archive ### API - [ ] Archive package via POST → verify hidden from list endpoint - [ ] Archived package keys still validate via POST /validate - [ ] Unarchive package → verify returns to list - [ ] Generate key from archived package → verify rejected ### GUI - [ ] Archive button (orange) visible on non-master packages - [ ] Collapsible "Archived Packages" section appears with count - [ ] Unarchive (reply icon) restores to main list - [ ] Delete button only for owners in archived section - [ ] Archive modal confirmation appears 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jmiller added the pending: testing label 2026-06-01 10:13:50 +00:00
jmiller reopened this issue 2026-06-02 11:21:41 +00:00
jmiller commented 2026-06-03 00:39:43 +00:00
Author
Owner
Copy Link
Copy Source

Tested and verified in production on MokoWaaS. All three download gating modes (none/prerelease/all), feed visibility, XML metadata, download URLs, and access control confirmed working.

Tested and verified in production on MokoWaaS. All three download gating modes (none/prerelease/all), feed visibility, XML metadata, download URLs, and access control confirmed working.
Sign in to join this conversation.
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 pending: testing
Feature implemented but not yet tested with documented proof
 priority: critical
Must fix immediately
 priority: high
Important, fix soon
 priority: low
Nice to have
 priority: medium
Normal priority
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 status: blocked
Blocked by dependency or decision
 status: in-progress
Actively being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Paused intentionally
 status: wontfix
Will not be addressed
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 type: bug
Something isn't working
 type: bug
type: chore
Maintenance, dependencies, cleanup
 type: enhancement
Improvement to existing feature
 type: feature
New functionality
 type: refactor
Code restructuring without behavior change
 type: version
Version bump or release
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels pending: testing
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea#384
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?