MokoConsulting/MokoGitea
1
0
Fork 0
Code Issues 142 Pull Requests Releases 90 Wiki Activity

fix: tech-debt batch 2 — dropdown validation, editor cleanup, rename #350

Merged
jmiller merged 1 commits from fix/tech-debt-batch-2 into dev 2026-05-31 15:52:31 +00:00
Conversation 0 Commits 1 Files Changed 9
+26 -30
jmiller commented 2026-05-31 15:51:29 +00:00
Owner
Copy Link
Copy Source

Summary

  • Issue dropdown validation: Add required attribute to hidden input in issue template dropdown fields, matching other field types
  • EditorMarkdown cleanup: Remove redundant handled boolean from MarkdownHandleIndentionResult — checking valueSelection alone is sufficient
  • Rename HasOrgOrUserVisible → IsOwnerVisibleToDoer: Clearer name expressing intent (checks if the repo owner is visible to the requesting user)

Refs #311, #334

Test plan

  • Run pnpm exec vitest web_src/js/features/comp/EditorMarkdown — tests updated
  • Verify issue templates with required dropdowns still validate on submit
  • Verify org/user visibility checks work (private org repos, anonymous access)

🤖 Generated with Claude Code

## Summary - **Issue dropdown validation**: Add `required` attribute to hidden input in issue template dropdown fields, matching other field types - **EditorMarkdown cleanup**: Remove redundant `handled` boolean from `MarkdownHandleIndentionResult` — checking `valueSelection` alone is sufficient - **Rename `HasOrgOrUserVisible` → `IsOwnerVisibleToDoer`**: Clearer name expressing intent (checks if the repo owner is visible to the requesting user) Refs #311, #334 ## Test plan - [ ] Run `pnpm exec vitest web_src/js/features/comp/EditorMarkdown` — tests updated - [ ] Verify issue templates with required dropdowns still validate on submit - [ ] Verify org/user visibility checks work (private org repos, anonymous access) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jmiller added 1 commit 2026-05-31 15:51:30 +00:00
fix: resolve tech-debt batch 2 — dropdown validation, editor cleanup, rename
Branch Policy Check / Verify merge target (pull_request) Successful in 1s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
PR RC Release / Build RC Release (pull_request) Successful in 3s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 6s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
d74ae92e5b 
- fix(templates): add required validation to issue dropdown fields
- refactor(ts): remove redundant `handled` field from MarkdownHandleIndentionResult
- refactor(go): rename HasOrgOrUserVisible to IsOwnerVisibleToDoer for clarity

Refs #311, #334

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jmiller merged commit d4bb976544 into dev 2026-05-31 15:52:31 +00:00
jmiller deleted branch fix/tech-debt-batch-2 2026-05-31 15:52:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 pending: testing
Feature implemented but not yet tested with documented proof
 priority: critical
Must fix immediately
 priority: high
Important, fix soon
 priority: low
Nice to have
 priority: medium
Normal priority
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 status: blocked
Blocked by dependency or decision
 status: in-progress
Actively being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Paused intentionally
 status: wontfix
Will not be addressed
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 type: bug
Something isn't working
 type: bug
type: chore
Maintenance, dependencies, cleanup
 type: enhancement
Improvement to existing feature
 type: feature
New functionality
 type: refactor
Code restructuring without behavior change
 type: version
Version bump or release
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea#350
Delete Branch "fix/tech-debt-batch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?