MokoConsulting/MokoGitea
1
0
Fork 0
Code Issues 145 Pull Requests Releases 96 Wiki Activity

tech-debt: Clean up User model design issues #314

New Issue
Open
opened 2026-05-31 14:15:02 +00:00 by jmiller · 0 comments
jmiller commented 2026-05-31 14:15:02 +00:00
Owner
Copy Link
Copy Source

Summary

The User model has multiple design issues flagged by FIXMEs.

Locations

  • models/user/user.go:193 - email does not need to be lowercase
  • models/user/user.go:261 - callers can only return ErrReachLimitOfRepo
  • models/user/user.go:408 - clarify password behavior for different types
  • models/user/user.go:451 - DefaultShowFullName causes messy logic
  • models/user/user.go:928 - need cache or db to store value
  • models/user/user.go:1191 - ValidateCommitsWithEmails uses Author but ParseCommitsWithSignature uses Committer
  • models/user/user.go:1339 - empty User fields do not apply correctly

Action Required

Address each design issue, particularly the Author vs Committer inconsistency and the empty-fields bug.

Created by Claude Opus 4.6

## Summary The User model has multiple design issues flagged by FIXMEs. ## Locations - `models/user/user.go:193` - email does not need to be lowercase - `models/user/user.go:261` - callers can only return ErrReachLimitOfRepo - `models/user/user.go:408` - clarify password behavior for different types - `models/user/user.go:451` - DefaultShowFullName causes messy logic - `models/user/user.go:928` - need cache or db to store value - `models/user/user.go:1191` - ValidateCommitsWithEmails uses Author but ParseCommitsWithSignature uses Committer - `models/user/user.go:1339` - empty User fields do not apply correctly ## Action Required Address each design issue, particularly the Author vs Committer inconsistency and the empty-fields bug. --- *Created by Claude Opus 4.6*
jmiller added the tech-debtupstream labels 2026-05-31 14:15:02 +00:00
Sign in to join this conversation.
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 pending: testing
Feature implemented but not yet tested with documented proof
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels tech-debt upstream
Status —
Type Bug
Status —
Priority —
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea#314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?