MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 136 Pull Requests Releases 96 Wiki Activity

fix(ci): robust prod deploy — remove dev-health gate, kill tier-clobbering sed, rm -f before recreate #758

Merged
jmiller merged 1 commits from fix/deploy-mokogitea-robustness into main 2026-07-06 15:57:54 +00:00
Conversation 1 Commits 1 Files Changed 1
+14 -14
jmiller commented 2026-07-06 15:57:15 +00:00
Owner
Copy Link
Copy Source

Repairs deploy-mokogitea.yml (prod deploy, on: push [main]) after it failed the #733 release and silently corrupted the shared compose. Three distinct false-negative / damage sources fixed:

1. Cross-tier false-negative gate (removed)

Step 0 "Verify dev environment is healthy" curled git.dev/api/healthz and exit 1 on failure — gating a PROD deploy on a live DEV health check. A transient dev blip false-negatives the prod deploy. Removed; the dev → rc → main pipeline + RC env is the real pre-prod gate.

2. Tier-clobbering sed (replaced with env-var pattern)

sed -i 's|mokogitea:[^ ]*|mokogitea:$TAG|' matched every mokogitea: line in the shared compose — it overwrote the dev and rc services' ${MOKOGITEA_DEV_TAG}/${MOKOGITEA_RC_TAG} env-vars with the prod tag (confirmed: dev+rc lines were clobbered to stable-289, dev container ended up running the prod image). Replaced with env $TAG_ENV="$TAG" docker compose up driving only the target service — no sed.

3. Container-name conflict (the actual failure)

docker compose up -d $CONTAINER without removing the fixed-name container + wrong compose project → Container name "/mokogitea" is already in use. Now: docker rm -f $CONTAINER + -p gitea-dev + --force-recreate.

Aligns deploy-mokogitea.yml with the already-fixed deploy-dev/deploy-rc pattern. The host compose was separately restored to env-var form for all three tiers (the bad run's damage). The #733 release itself is live + healthy (completed via manual fallback).

Long-term: cut over Template-Go#5 deploy-prod.yml to retire this custom copy. Refs #733, #752.

https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT

Repairs `deploy-mokogitea.yml` (prod deploy, `on: push [main]`) after it failed the #733 release **and silently corrupted the shared compose**. Three distinct false-negative / damage sources fixed: ## 1. Cross-tier false-negative gate (removed) Step 0 "Verify dev environment is healthy" curled `git.dev/api/healthz` and `exit 1` on failure — **gating a PROD deploy on a live DEV health check.** A transient dev blip false-negatives the prod deploy. Removed; the `dev → rc → main` pipeline + RC env is the real pre-prod gate. ## 2. Tier-clobbering `sed` (replaced with env-var pattern) `sed -i 's|mokogitea:[^ ]*|mokogitea:$TAG|'` matched **every** `mokogitea:` line in the shared compose — it overwrote the **dev and rc** services' `${MOKOGITEA_DEV_TAG}`/`${MOKOGITEA_RC_TAG}` env-vars with the prod tag (confirmed: dev+rc lines were clobbered to `stable-289`, dev container ended up running the prod image). Replaced with `env $TAG_ENV="$TAG" docker compose up` driving **only the target service** — no sed. ## 3. Container-name conflict (the actual failure) `docker compose up -d $CONTAINER` without removing the fixed-name container + wrong compose project → `Container name "/mokogitea" is already in use`. Now: `docker rm -f $CONTAINER` + `-p gitea-dev` + `--force-recreate`. Aligns `deploy-mokogitea.yml` with the already-fixed `deploy-dev`/`deploy-rc` pattern. The **host compose was separately restored** to env-var form for all three tiers (the bad run's damage). The #733 release itself is live + healthy (completed via manual fallback). Long-term: cut over Template-Go#5 `deploy-prod.yml` to retire this custom copy. Refs #733, #752. https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT
jmiller added 1 commit 2026-07-06 15:57:16 +00:00
fix(ci): robust prod deploy — drop dev-health gate, no tier-clobbering sed, rm -f before recreate
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 42s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Successful in 2s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 8s
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 36s
Details
Generic: Project CI / Tests (pull_request) Successful in 36s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 56s
Details
Universal: PR Check / Require Docs Update (pull_request) Failing after 1m11s
Details
PR RC Release / Build RC Release (pull_request) Successful in 1m13s
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
a7220ddb2b 
The prod deploy (deploy-mokogitea.yml, on push to main) failed the #733 release and
silently corrupted the shared compose. Three fixes:
- Removed the 'Verify dev environment is healthy' gate: it curled git.dev and exit 1
  on failure, so a dev blip false-negatives the PROD deploy (wrong-tier gate; the
  dev->rc->main pipeline + RC env is the real gate).
- Replaced 'sed s|mokogitea:...|:$TAG|' (matched ALL mokogitea service lines and
  clobbered the dev+rc ${MOKOGITEA_*_TAG} env-vars with the prod tag) with the
  env-var pattern: env $TAG_ENV=$TAG docker compose up -- drives only the target
  service, no sed.
- Added 'docker rm -f $CONTAINER' + '-p gitea-dev' + '--force-recreate' before the
  compose up, fixing the 'Container name /mokogitea already in use' conflict.

Aligns deploy-mokogitea.yml with the fixed deploy-dev/deploy-rc pattern. Host compose
was separately restored to env-var form (the bad run had clobbered dev+rc tags).
Long-term: cut over Template-Go#5 deploy-prod.yml. Refs #733, #752.

Claude-Session: https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT
jmiller commented 2026-07-06 15:57:20 +00:00
Author
Owner
Copy Link
Copy Source

Wiki reminder: docs are wiki-first -- if this PR changes behavior, usage, config, or standards, please update the repo wiki before/after merge. (non-blocking)

<!-- wiki-reminder --> **Wiki reminder:** docs are wiki-first -- if this PR changes behavior, usage, config, or standards, please update the repo wiki before/after merge. _(non-blocking)_
jmiller merged commit 8242e5713a into main 2026-07-06 15:57:54 +00:00
jmiller deleted branch fix/deploy-mokogitea-robustness 2026-07-06 15:57:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#758
Delete Branch "fix/deploy-mokogitea-robustness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?