fix: feed generator should use FullElementName() instead of raw ElementName #604

New Issue

2026-06-11T21:15:34Z

jmiller commented

2026-06-11 21:15:34 +00:00

Problem

resolveExtensionMetadata() in services/updateserver/joomla.go reads manifest.ElementName directly (line 195). If ElementName is empty but Name and PackageType are set, the auto-construction logic in FullElementName() would produce the correct element (e.g. pkg_ + mokosuitehq → pkg_mokosuitehq), but it's never called.

Expected

The feed generator should call manifest.FullElementName() which returns the override if set, otherwise auto-constructs from PackageType + Name.

Fix

In services/updateserver/joomla.go line 195, replace:

if manifest.ElementName != "" {
    m.Element = manifest.ElementName
}

With:

if elem := manifest.FullElementName(); elem != "" {
    m.Element = elem
}

Impact

Repos that have Name and PackageType set in their manifest but no explicit ElementName override will fall back to the repo name instead of getting the correct auto-constructed element name.

## Problem `resolveExtensionMetadata()` in `services/updateserver/joomla.go` reads `manifest.ElementName` directly (line 195). If `ElementName` is empty but `Name` and `PackageType` are set, the auto-construction logic in `FullElementName()` would produce the correct element (e.g. `pkg_` + `mokosuitehq` → `pkg_mokosuitehq`), but it's never called. ## Expected The feed generator should call `manifest.FullElementName()` which returns the override if set, otherwise auto-constructs from `PackageType` + `Name`. ## Fix In `services/updateserver/joomla.go` line 195, replace: ```go if manifest.ElementName != "" { m.Element = manifest.ElementName } ``` With: ```go if elem := manifest.FullElementName(); elem != "" { m.Element = elem } ``` ## Impact Repos that have `Name` and `PackageType` set in their manifest but no explicit `ElementName` override will fall back to the repo name instead of getting the correct auto-constructed element name.

~~jmiller referenced this issue 2026-06-11 21:16:36 +00:00~~

fix: update server feed generation bugs in joomla.go #601

jmiller closed this issue

2026-06-11 21:22:41 +00:00

Sign in to join this conversation.

Priority Medium

Type Feature

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#604