MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 172 Pull Requests 1 Releases 96 Wiki Activity

fix: pre-release version suffix number lost in update feed #603

New Issue
Closed
opened 2026-06-11 21:15:27 +00:00 by jmiller · 0 comments
jmiller commented 2026-06-11 21:15:27 +00:00
Owner
Copy Link
Copy Source

Problem

extractVersion() in services/updateserver/joomla.go strips pre-release suffixes (e.g. -rc2) completely, then the stream suffix re-appends just the base suffix (e.g. -rc). The numeric part is lost.

Example

Tag v1.2.3-rc2 → extracted as 1.2.3 → stream suffix appended → 1.2.3-rc

A user on 1.2.3-rc1 (also shown as 1.2.3-rc) would not be prompted to update to 1.2.3-rc2 because Joomla sees them as identical versions.

Expected

The version should preserve the numeric suffix: 1.2.3-rc2

Fix

In extractVersion() (lines 444-468), preserve the numeric part after the channel suffix during extraction. One approach: capture the number after the channel suffix and include it, or skip stripping when the stream suffix will be re-appended.

Impact

Pre-release update notifications between RC/beta/alpha versions of the same base version don't work.

## Problem `extractVersion()` in `services/updateserver/joomla.go` strips pre-release suffixes (e.g. `-rc2`) completely, then the stream suffix re-appends just the base suffix (e.g. `-rc`). The numeric part is lost. ## Example Tag `v1.2.3-rc2` → extracted as `1.2.3` → stream suffix appended → `1.2.3-rc` A user on `1.2.3-rc1` (also shown as `1.2.3-rc`) would not be prompted to update to `1.2.3-rc2` because Joomla sees them as identical versions. ## Expected The version should preserve the numeric suffix: `1.2.3-rc2` ## Fix In `extractVersion()` (lines 444-468), preserve the numeric part after the channel suffix during extraction. One approach: capture the number after the channel suffix and include it, or skip stripping when the stream suffix will be re-appended. ## Impact Pre-release update notifications between RC/beta/alpha versions of the same base version don't work.
Sign in to join this conversation.
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?