feat(repo): enforce dot-prefixed repos as always-private system repos #77

Merged

jmiller merged 1 commits from feature/system-repo-private into main 2026-05-13 00:16:13 +00:00

Conversation 0 Commits 1 Files Changed 10

+52 -14

jmiller commented 2026-05-13 00:15:51 +00:00

Owner

Copy Link

Copy Source

Summary

• Repositories with names starting with . are now treated as system repositories that are always private and cannot be made public
• On creation paths (API, web, migrate, template, push-to-create), privacy is silently forced
• On edit paths (API edit, web settings, public access settings), a clear error is returned
• UI disables the "Make Public" button for system repos by setting ForcePrivate in template context

Files Changed (10)

Layer	File	Behavior
Model	models/repo/repo.go	IsSystemRepo() � name starts with .
Service	services/repository/repository.go	MakeRepoPrivate() guard � hard error
API Create	routers/api/v1/repo/repo.go	Silent force private
API Edit	routers/api/v1/repo/repo.go	403 Forbidden
API Migrate	routers/api/v1/repo/migrate.go	Silent force private
Web Create	routers/web/repo/repo.go	Silent force private
Web Migrate	routers/web/repo/migrate.go	Silent force private
Web Settings	routers/web/repo/setting/setting.go	UI disabled + hard error
Public Access	routers/web/repo/setting/public_access.go	UI disabled + redirect
Push Hook	routers/private/hook_post_receive.go	Silent ignore + log warning
Locale	options/locale/locale_en-US.json	Error message string

Test plan

• Create a repo named .test-system via API � verify it is created as private
• Create a repo named .test-system-web via web UI � verify it is created as private
• Try to edit .test-system visibility to public via API � verify 403 response
• Try to change visibility to public via web settings � verify error message
• Verify normal (non-dot) repos are unaffected

?? Generated with Claude Code

## Summary - Repositories with names starting with `.` are now treated as **system repositories** that are always private and cannot be made public - On creation paths (API, web, migrate, template, push-to-create), privacy is silently forced - On edit paths (API edit, web settings, public access settings), a clear error is returned - UI disables the "Make Public" button for system repos by setting `ForcePrivate` in template context ## Files Changed (10) | Layer | File | Behavior | |---|---|---| | Model | `models/repo/repo.go` | `IsSystemRepo()` � name starts with `.` | | Service | `services/repository/repository.go` | `MakeRepoPrivate()` guard � hard error | | API Create | `routers/api/v1/repo/repo.go` | Silent force private | | API Edit | `routers/api/v1/repo/repo.go` | 403 Forbidden | | API Migrate | `routers/api/v1/repo/migrate.go` | Silent force private | | Web Create | `routers/web/repo/repo.go` | Silent force private | | Web Migrate | `routers/web/repo/migrate.go` | Silent force private | | Web Settings | `routers/web/repo/setting/setting.go` | UI disabled + hard error | | Public Access | `routers/web/repo/setting/public_access.go` | UI disabled + redirect | | Push Hook | `routers/private/hook_post_receive.go` | Silent ignore + log warning | | Locale | `options/locale/locale_en-US.json` | Error message string | ## Test plan - [ ] Create a repo named `.test-system` via API � verify it is created as private - [ ] Create a repo named `.test-system-web` via web UI � verify it is created as private - [ ] Try to edit `.test-system` visibility to public via API � verify 403 response - [ ] Try to change visibility to public via web settings � verify error message - [ ] Verify normal (non-dot) repos are unaffected ?? Generated with [Claude Code](https://claude.com/claude-code)

jmiller added 1 commit 2026-05-13 00:15:52 +00:00

feat(repo): enforce dot-prefixed repos as always-private system repos ... c5eb8df8a2

Repositories with names starting with "." are now treated as system
repositories that are always private and cannot be made public. This is
enforced at every code path: API create, web create, migrate, template
create, push-to-create, API edit, web settings, and public access
settings. On creation paths, privacy is silently forced. On edit paths,
a clear error is returned.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jmiller merged commit ef6a7dcfcf into main 2026-05-13 00:16:13 +00:00

jmiller referenced this issue from a commit 2026-05-13 00:16:13 +00:00

Merge pull request 'feat(repo): enforce dot-prefixed repos as always-private system repos' (#77) from feature/system-repo-private into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

breaking-change

Breaking API or behavior change

ci-cd

CI/CD pipeline changes

config

Configuration changes

dependencies

Dependency updates

deploy-failure

Deployment failed

docker

Docker/container changes

documentation

Documentation changes

good first issue

Good for newcomers

health-check

Repo health check result

help wanted

Extra attention needed

mokostandards

Related to MokoStandards framework

push-failure

Git push operation failed

security

Security vulnerability or hardening

size/l

200-500 lines changed

size/m

50-200 lines changed

size/s

10-50 lines changed

size/xl

500+ lines changed

size/xs

< 10 lines changed

standards-drift

Deviates from MokoStandards

standards-update

MokoStandards compliance update

sync-failure

Sync or mirror failed

tech-debt

Technical debt and TODO/FIXME items

upstream

upstream

Inherited from upstream Gitea

work-in-progress

Draft or incomplete work

No labels

Priority -

Type -

Status —

Priority —

Type —

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#77