bug: update server feeds still respond when feature is disabled #589

New Issue

2026-06-07T20:42:22Z

jmiller commented

2026-06-07 20:42:22 +00:00

Problem

The update server endpoints (/updates.xml, /updates/dolibarr.json, etc.) still respond with valid feed data even when the update server feature is disabled for a repo.

PR #579 fixed the settings persistence side (deleting the repo config row when the toggle is unchecked), but the RepoAssignmentPublicFeed middleware in services/context/repo_public_feed.go does not check whether LicensingEnabled is true. When no repo config exists, it defaults to platform "joomla" and allows the request through.

Expected Behavior

When the update server is disabled (no repo-level config with LicensingEnabled=true AND no org-level config with LicensingEnabled=true), the feed endpoints should return 404.

Fix

The RepoAssignmentPublicFeed middleware needs to check LicensingEnabled on both the repo config and org config, returning 404 if neither has it enabled.

Fix is on branch chore/mcp-cleanup.

## Problem The update server endpoints (`/updates.xml`, `/updates/dolibarr.json`, etc.) still respond with valid feed data even when the update server feature is disabled for a repo. PR #579 fixed the settings persistence side (deleting the repo config row when the toggle is unchecked), but the `RepoAssignmentPublicFeed` middleware in `services/context/repo_public_feed.go` does not check whether `LicensingEnabled` is true. When no repo config exists, it defaults to platform `"joomla"` and allows the request through. ## Expected Behavior When the update server is disabled (no repo-level config with `LicensingEnabled=true` AND no org-level config with `LicensingEnabled=true`), the feed endpoints should return 404. ## Fix The `RepoAssignmentPublicFeed` middleware needs to check `LicensingEnabled` on both the repo config and org config, returning 404 if neither has it enabled. Fix is on branch `chore/mcp-cleanup`.

jmiller commented

2026-06-07 20:42:27 +00:00

Branch created: feature/589-bug-update-server-feeds-still-respond-wh

git fetch origin
git checkout feature/589-bug-update-server-feeds-still-respond-wh

Branch created: [`feature/589-bug-update-server-feeds-still-respond-wh`](https://code.mokoconsulting.tech/MokoConsulting/MokoGitea-APP/src/branch/feature/589-bug-update-server-feeds-still-respond-wh) ```bash git fetch origin git checkout feature/589-bug-update-server-feeds-still-respond-wh ```

Sign in to join this conversation.

Priority -

Type -

Status —

Priority —

Type —

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#589