MokoConsulting/MokoGitea-APP
1
0
Fork 0
Code Issues 158 Pull Requests 3 Releases 96 Wiki Activity

feat(manifest): consolidate update server settings into manifest #582

New Issue
Closed
opened 2026-06-07 18:20:36 +00:00 by jmiller · 1 comment
jmiller commented 2026-06-07 18:20:36 +00:00
Owner
Copy Link
Copy Source

Problem

Update server metadata is duplicated between UpdateStreamConfig and RepoManifest. Fields like extension name, display name, maintainer, target version, PHP minimum, and extension type exist in the update stream config but should live in the manifest as the single source of truth.

Current State

UpdateStreamConfig has these fields that overlap with or should come from manifest:

  • ExtensionName - already in manifest as Name + auto-constructed ElementName
  • DisplayName - should be a manifest field
  • Description - already in manifest
  • ExtensionType - already in manifest as PackageType
  • Maintainer - should be a manifest field
  • MaintainerURL - should be a manifest field
  • InfoURL - should be a manifest field
  • TargetVersion - should be a manifest field (platform-specific)
  • PHPMinimum - should be a manifest field (platform-specific)

UpdateStreamConfig should keep only:

  • LicensingEnabled (rename to update server enabled)
  • RequireKey
  • FeedVisibility
  • DownloadGating
  • SupportURL
  • KeyPrefix
  • StreamMode + CustomStreams

Plan

  1. Add missing fields to RepoManifest: DisplayName, Maintainer, MaintainerURL, InfoURL, TargetVersion, PHPMinimum
  2. Add these to manifest settings UI (platform-conditional - show TargetVersion and PHPMinimum only for joomla/wordpress)
  3. Add to manifest API and XML parser
  4. Update feed generator to read from manifest instead of UpdateStreamConfig
  5. Remove duplicate fields from UpdateStreamConfig model (keep backward compat by reading from manifest if config field is empty)
  6. Remove duplicate fields from update stream settings UI
  7. Rename "Enable Licensing" to "Enable Update Server" in UI
  8. Update detect_platform CLI to populate manifest from Joomla/Dolibarr manifest files

Migration Path

  • Phase 1: Add fields to manifest, read from manifest first with fallback to UpdateStreamConfig
  • Phase 2: Migrate existing UpdateStreamConfig values to manifest via migration
  • Phase 3: Remove deprecated fields from UpdateStreamConfig

Related

  • Platform dropdown already updated to joomla/dolibarr/go/mcp/platform/generic
  • Element name auto-construction already implemented
  • Update server disable bug already fixed (#577)
## Problem Update server metadata is duplicated between `UpdateStreamConfig` and `RepoManifest`. Fields like extension name, display name, maintainer, target version, PHP minimum, and extension type exist in the update stream config but should live in the manifest as the single source of truth. ## Current State **UpdateStreamConfig** has these fields that overlap with or should come from manifest: - `ExtensionName` - already in manifest as `Name` + auto-constructed `ElementName` - `DisplayName` - should be a manifest field - `Description` - already in manifest - `ExtensionType` - already in manifest as `PackageType` - `Maintainer` - should be a manifest field - `MaintainerURL` - should be a manifest field - `InfoURL` - should be a manifest field - `TargetVersion` - should be a manifest field (platform-specific) - `PHPMinimum` - should be a manifest field (platform-specific) **UpdateStreamConfig** should keep only: - `LicensingEnabled` (rename to update server enabled) - `RequireKey` - `FeedVisibility` - `DownloadGating` - `SupportURL` - `KeyPrefix` - `StreamMode` + `CustomStreams` ## Plan 1. Add missing fields to `RepoManifest`: `DisplayName`, `Maintainer`, `MaintainerURL`, `InfoURL`, `TargetVersion`, `PHPMinimum` 2. Add these to manifest settings UI (platform-conditional - show `TargetVersion` and `PHPMinimum` only for joomla/wordpress) 3. Add to manifest API and XML parser 4. Update feed generator to read from manifest instead of `UpdateStreamConfig` 5. Remove duplicate fields from `UpdateStreamConfig` model (keep backward compat by reading from manifest if config field is empty) 6. Remove duplicate fields from update stream settings UI 7. Rename "Enable Licensing" to "Enable Update Server" in UI 8. Update `detect_platform` CLI to populate manifest from Joomla/Dolibarr manifest files ## Migration Path - Phase 1: Add fields to manifest, read from manifest first with fallback to UpdateStreamConfig - Phase 2: Migrate existing UpdateStreamConfig values to manifest via migration - Phase 3: Remove deprecated fields from UpdateStreamConfig ## Related - Platform dropdown already updated to joomla/dolibarr/go/mcp/platform/generic - Element name auto-construction already implemented - Update server disable bug already fixed (#577)
jmiller commented 2026-06-07 18:20:38 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/582-feat-manifest-consolidate-update-server-

git fetch origin
git checkout feature/582-feat-manifest-consolidate-update-server-
Branch created: [`feature/582-feat-manifest-consolidate-update-server-`](https://git.mokoconsulting.tech/MokoConsulting/MokoGitea/src/branch/feature/582-feat-manifest-consolidate-update-server-) ```bash git fetch origin git checkout feature/582-feat-manifest-consolidate-update-server- ```
Sign in to join this conversation.
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?