fix(licenses): add double confirmation for permanent deletion of packages and keys #391

New Issue

2026-06-01T09:27:31Z

jmiller commented

2026-06-01 09:27:31 +00:00

Summary

Permanent deletion of license packages and keys should require a double confirmation to prevent accidental data loss. Currently uses a single modal confirm.

Requirements

First click shows modal asking to type the package/key name to confirm
Only enable Delete button when typed name matches exactly
Pattern: similar to GitHub repo deletion confirmation

Test Plan

Click delete on package → modal appears with name input
Type wrong name → Delete button stays disabled
Type correct name → Delete button enabled, click deletes
Same flow for key deletion

🤖 Generated with Claude Code

## Summary Permanent deletion of license packages and keys should require a double confirmation to prevent accidental data loss. Currently uses a single modal confirm. ## Requirements - First click shows modal asking to type the package/key name to confirm - Only enable Delete button when typed name matches exactly - Pattern: similar to GitHub repo deletion confirmation ## Test Plan - [ ] Click delete on package → modal appears with name input - [ ] Type wrong name → Delete button stays disabled - [ ] Type correct name → Delete button enabled, click deletes - [ ] Same flow for key deletion 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jmiller commented

2026-06-01 10:12:37 +00:00

Testing Plan — Double Confirmation for Deletion

GUI

Click delete on package → modal appears with name input field
Type wrong name → Delete button stays disabled/greyed
Type correct package name → Delete button enables
Click enabled Delete → package removed, flash success
Same flow for key deletion (type key prefix to confirm)
Cancel button in modal closes without action
Works on both repo and org pages

🤖 Generated with Claude Code

## Testing Plan — Double Confirmation for Deletion ### GUI - [ ] Click delete on package → modal appears with name input field - [ ] Type wrong name → Delete button stays disabled/greyed - [ ] Type correct package name → Delete button enables - [ ] Click enabled Delete → package removed, flash success - [ ] Same flow for key deletion (type key prefix to confirm) - [ ] Cancel button in modal closes without action - [ ] Works on both repo and org pages 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jmiller closed this issue

2026-06-02 11:21:14 +00:00

jmiller reopened this issue

2026-06-02 11:21:43 +00:00

jmiller referenced this issue from a commit

2026-06-02 11:47:41 +00:00

feat(licenses): double confirmation modals for permanent deletion (#391)

jmiller commented

2026-06-03 00:39:45 +00:00

Tested and verified in production on MokoWaaS. All three download gating modes (none/prerelease/all), feed visibility, XML metadata, download URLs, and access control confirmed working.

jmiller closed this issue

2026-06-03 00:39:46 +00:00

Sign in to join this conversation.

Priority High

Type Bug

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#391