chore: remove old manifest files (consolidated into metadata)

routers/web/repo/setting/manifest.go

@@ -1,240 +0,0 @@
-// Copyright 2026 Moko Consulting <hello@mokoconsulting.tech>
-// SPDX-License-Identifier: GPL-3.0-or-later
-
-package setting
-
-import (
-	"encoding/xml"
-	"fmt"
-	"net/http"
-
-	updateserver_model "code.mokoconsulting.tech/MokoConsulting/MokoGitea/models/updateserver"
-	repo_model "code.mokoconsulting.tech/MokoConsulting/MokoGitea/models/repo"
-	"code.mokoconsulting.tech/MokoConsulting/MokoGitea/modules/log"
-	"code.mokoconsulting.tech/MokoConsulting/MokoGitea/modules/templates"
-	"code.mokoconsulting.tech/MokoConsulting/MokoGitea/services/context"
-)
-
-const tplSettingsManifest templates.TplName = "repo/settings/manifest"
-
-// manifestXML mirrors the .mokogitea/manifest.xml schema for XML parsing.
-type manifestXML struct {
-	XMLName      xml.Name             `xml:"mokoplatform"`
-	Identity     manifestIdentity     `xml:"identity"`
-	Governance   manifestGovernance   `xml:"governance"`
-	Distribution manifestDistribution `xml:"distribution"`
-	Build        manifestBuild        `xml:"build"`
-}
-
-type manifestIdentity struct {
-	Name          string          `xml:"name"`
-	Org           string          `xml:"org"`
-	Description   string          `xml:"description"`
-	Version       string          `xml:"version"`
-	VersionPrefix string          `xml:"version-prefix"`
-	License       manifestLicense `xml:"license"`
-}
-
-type manifestLicense struct {
-	SPDX string `xml:"spdx,attr"`
-	Name string `xml:",chardata"`
-}
-
-type manifestGovernance struct {
-	Platform         string `xml:"platform"`
-	StandardsVersion string `xml:"standards-version"`
-	StandardsSource  string `xml:"standards-source"`
-}
-
-type manifestDistribution struct {
-	DisplayName   string `xml:"display-name"`
-	Maintainer    string `xml:"maintainer"`
-	MaintainerURL string `xml:"maintainer-url"`
-	InfoURL       string `xml:"info-url"`
-	TargetVersion string `xml:"target-version"`
-	PHPMinimum    string `xml:"php-minimum"`
-}
-
-type manifestBuild struct {
-	Language    string `xml:"language"`
-	PackageType string `xml:"package-type"`
-	EntryPoint  string `xml:"entry-point"`
-}
-
-// ManifestSettings displays the repo manifest settings page.
-// On first visit, if no manifest exists in DB but .mokogitea/manifest.xml
-// exists in the repo, it auto-migrates the XML values into the database.
-func ManifestSettings(ctx *context.Context) {
-	ctx.Data["Title"] = ctx.Tr("repo.settings.manifest")
-	ctx.Data["PageIsSettingsManifest"] = true
-
-	repoID := ctx.Repo.Repository.ID
-	manifest, err := repo_model.GetRepoManifest(ctx, repoID)
-	if err != nil {
-		ctx.ServerError("GetRepoManifest", err)
-		return
-	}
-
-	// Auto-detect and migrate .mokogitea/manifest.xml if no DB record exists.
-	if manifest == nil {
-		manifest = tryMigrateManifestXML(ctx)
-	}
-
-	if manifest == nil {
-		// No manifest found — provide empty defaults from repo metadata.
-		manifest = &repo_model.RepoManifest{
-			RepoID:      repoID,
-			Name:        ctx.Repo.Repository.Name,
-			Org:         ctx.Repo.Repository.OwnerName,
-			Description: ctx.Repo.Repository.Description,
-		}
-	}
-
-	ctx.Data["Manifest"] = manifest
-
-	// Load update server / licensing config for the combined page.
-	repoCfg, _ := updateserver_model.GetRepoConfig(ctx, ctx.Repo.Repository.ID)
-	ctx.Data["RepoUpdateConfig"] = repoCfg
-
-	ctx.HTML(http.StatusOK, tplSettingsManifest)
-}
-
-// ManifestSettingsPost saves manifest or licensing settings from the form.
-func ManifestSettingsPost(ctx *context.Context) {
-	// Handle licensing sub-form.
-	if ctx.FormString("action") == "licensing" {
-		saveLicensingSettings(ctx)
-		return
-	}
-
-	manifest := &repo_model.RepoManifest{
-		RepoID:           ctx.Repo.Repository.ID,
-		Name:             ctx.FormString("name"),
-		Org:              ctx.FormString("org"),
-		Description:      ctx.Repo.Repository.Description,
-		Version:          ctx.FormString("version"),
-		LicenseSPDX:      ctx.FormString("license_spdx"),
-		LicenseName:      ctx.FormString("license_name"),
-		VersionPrefix:    ctx.FormString("version_prefix"),
-		ElementName:      ctx.FormString("element_name"),
-		Platform:         ctx.FormString("platform"),
-		StandardsVersion: ctx.FormString("standards_version"),
-		StandardsSource:  ctx.FormString("standards_source"),
-		DisplayName:      ctx.FormString("display_name"),
-		Maintainer:       ctx.FormString("maintainer"),
-		MaintainerURL:    ctx.FormString("maintainer_url"),
-		InfoURL:          ctx.FormString("info_url"),
-		TargetVersion:    ctx.FormString("target_version"),
-		PHPMinimum:       ctx.FormString("php_minimum"),
-		Language:         ctx.FormString("language"),
-		PackageType:      ctx.FormString("package_type"),
-		EntryPoint:       ctx.FormString("entry_point"),
-	}
-
-	if err := repo_model.CreateOrUpdateRepoManifest(ctx, manifest); err != nil {
-		ctx.ServerError("CreateOrUpdateRepoManifest", err)
-		return
-	}
-
-	ctx.Flash.Success(ctx.Tr("repo.settings.manifest_saved"))
-	ctx.Redirect(ctx.Repo.RepoLink + "/settings/manifest")
-}
-
-// saveLicensingSettings handles the update server / licensing form submission.
-func saveLicensingSettings(ctx *context.Context) {
-	repo := ctx.Repo.Repository
-
-	updatePlatform := ctx.FormString("update_platform")
-	if updatePlatform == "" {
-		updatePlatform = "joomla"
-	}
-
-	enabled := ctx.FormString("enable_licensing") == "on"
-
-	if !enabled {
-		if err := updateserver_model.DeleteRepoConfig(ctx, repo.ID); err != nil {
-			log.Error("DeleteRepoConfig: %v", err)
-		}
-	} else {
-		updateCfg := &updateserver_model.UpdateStreamConfig{
-			OwnerID:          repo.OwnerID,
-			RepoID:           repo.ID,
-			Platform:         updatePlatform,
-			LicensingEnabled: true,
-			RequireKey:       ctx.FormString("require_update_key") == "on",
-			DownloadGating:   ctx.FormString("download_gating"),
-			FeedVisibility:   ctx.FormString("feed_visibility"),
-			SupportURL:       ctx.FormString("support_url"),
-			StreamMode:       "joomla",
-		}
-
-		if err := updateserver_model.SaveConfig(ctx, updateCfg); err != nil {
-			log.Error("SaveConfig: %v", err)
-			ctx.ServerError("SaveConfig", err)
-			return
-		}
-	}
-
-	ctx.Flash.Success(ctx.Tr("repo.settings.update_settings_success"))
-	ctx.Redirect(ctx.Repo.RepoLink + "/settings/manifest")
-}
-
-// tryMigrateManifestXML reads .mokogitea/manifest.xml from the repo,
-// parses it, and stores the values in the DB. Returns nil if no file found.
-func tryMigrateManifestXML(ctx *context.Context) *repo_model.RepoManifest {
-	if ctx.Repo.GitRepo == nil || ctx.Repo.Commit == nil {
-		return nil
-	}
-
-	entry, err := ctx.Repo.Commit.GetTreeEntryByPath(".mokogitea/manifest.xml")
-	if err != nil || entry == nil {
-		return nil // no manifest.xml found — not an error
-	}
-
-	reader, err := entry.Blob().DataAsync()
-	if err != nil {
-		log.Error("ManifestMigrate: read blob: %v", err)
-		return nil
-	}
-	defer reader.Close()
-
-	var mxml manifestXML
-	if err := xml.NewDecoder(reader).Decode(&mxml); err != nil {
-		log.Error("ManifestMigrate: parse XML: %v", err)
-		return nil
-	}
-
-	manifest := &repo_model.RepoManifest{
-		RepoID:           ctx.Repo.Repository.ID,
-		Name:             mxml.Identity.Name,
-		Org:              mxml.Identity.Org,
-		Description:      mxml.Identity.Description,
-		Version:          mxml.Identity.Version,
-		LicenseSPDX:      mxml.Identity.License.SPDX,
-		LicenseName:      mxml.Identity.License.Name,
-		VersionPrefix:    mxml.Identity.VersionPrefix,
-		Platform:         mxml.Governance.Platform,
-		StandardsVersion: mxml.Governance.StandardsVersion,
-		StandardsSource:  mxml.Governance.StandardsSource,
-		DisplayName:      mxml.Distribution.DisplayName,
-		Maintainer:       mxml.Distribution.Maintainer,
-		MaintainerURL:    mxml.Distribution.MaintainerURL,
-		InfoURL:          mxml.Distribution.InfoURL,
-		TargetVersion:    mxml.Distribution.TargetVersion,
-		PHPMinimum:       mxml.Distribution.PHPMinimum,
-		Language:         mxml.Build.Language,
-		PackageType:      mxml.Build.PackageType,
-		EntryPoint:       mxml.Build.EntryPoint,
-	}
-
-	if err := repo_model.CreateOrUpdateRepoManifest(ctx, manifest); err != nil {
-		log.Error("ManifestMigrate: save to DB: %v", err)
-		return nil
-	}
-
-	log.Info("ManifestMigrate: migrated .mokogitea/manifest.xml for repo %s/%s",
-		ctx.Repo.Repository.OwnerName, ctx.Repo.Repository.Name)
-
-	ctx.Flash.Info(fmt.Sprintf("Manifest settings imported from .mokogitea/manifest.xml. You can now delete the file from the repository."))
-	return manifest
-}

templates/repo/settings/manifest.tmpl

@@ -1,223 +0,0 @@
-{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings manifest")}}
-<h4 class="ui top attached header">
-	{{ctx.Locale.Tr "repo.settings.manifest"}}
-</h4>
-<div class="ui attached segment">
-	<p class="text grey">{{ctx.Locale.Tr "repo.settings.manifest_desc"}}</p>
-
-	<form class="ui form" method="post" action="{{.RepoLink}}/settings/manifest">
-		{{.CsrfTokenHtml}}
-
-		<h5 class="ui dividing header">{{ctx.Locale.Tr "repo.settings.manifest_identity"}}</h5>
-		<div class="two fields">
-			<div class="field">
-				{{if eq .Manifest.Platform "joomla"}}
-					<label>{{ctx.Locale.Tr "repo.settings.manifest_element_name"}}</label>
-					<input name="name" value="{{.Manifest.Name}}" placeholder="e.g. mokowaas">
-					<p class="help">{{ctx.Locale.Tr "repo.settings.manifest_element_name_help"}}</p>
-				{{else}}
-					<label>{{ctx.Locale.Tr "repo.settings.manifest_name"}}</label>
-					<input name="name" value="{{.Manifest.Name}}" placeholder="Project name">
-				{{end}}
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_org"}}</label>
-				<input name="org" value="{{.Manifest.Org}}" placeholder="Organization">
-			</div>
-		</div>
-		<div class="four fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_version"}}</label>
-				<input name="version" value="{{.Manifest.Version}}" placeholder="e.g. 06.00.00">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_version_prefix"}}</label>
-				<input name="version_prefix" value="{{.Manifest.VersionPrefix}}" placeholder="e.g. v1.26.1-moko.">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_license_spdx"}}</label>
-				<input name="license_spdx" value="{{.Manifest.LicenseSPDX}}" placeholder="e.g. GPL-3.0-or-later">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_license_name"}}</label>
-				<input name="license_name" value="{{.Manifest.LicenseName}}" placeholder="e.g. GNU General Public License v3">
-			</div>
-		</div>
-
-		<h5 class="ui dividing header">{{ctx.Locale.Tr "repo.settings.manifest_governance"}}</h5>
-		<div class="three fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_platform"}}</label>
-				<select name="platform" class="ui dropdown">
-					<option value="">—</option>
-					{{$platform := .Manifest.Platform}}
-					{{range $val := StringUtils.Split "joomla,wordpress,dolibarr,go,mcp,platform,generic" ","}}
-						<option value="{{$val}}" {{if eq $val $platform}}selected{{end}}>{{$val}}</option>
-					{{end}}
-				</select>
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_standards_version"}}</label>
-				<input name="standards_version" value="{{.Manifest.StandardsVersion}}" placeholder="e.g. 05.00.00">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_standards_source"}}</label>
-				<input name="standards_source" value="{{.Manifest.StandardsSource}}" placeholder="URL to standards repo">
-			</div>
-		</div>
-
-		{{if or (eq .Manifest.Platform "joomla") (eq .Manifest.Platform "wordpress") (eq .Manifest.Platform "dolibarr")}}
-		<h5 class="ui dividing header">{{ctx.Locale.Tr "repo.settings.manifest_distribution"}}</h5>
-		<div class="two fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_display_name"}}</label>
-				<input name="display_name" value="{{.Manifest.DisplayName}}" placeholder="e.g. Package - MokoWaaS">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_info_url"}}</label>
-				<input name="info_url" value="{{.Manifest.InfoURL}}" placeholder="https://mokoconsulting.tech/product/...">
-			</div>
-		</div>
-		<div class="two fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_maintainer"}}</label>
-				<input name="maintainer" value="{{.Manifest.Maintainer}}" placeholder="Moko Consulting">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_maintainer_url"}}</label>
-				<input name="maintainer_url" value="{{.Manifest.MaintainerURL}}" placeholder="https://mokoconsulting.tech">
-			</div>
-		</div>
-		{{if or (eq .Manifest.Platform "joomla") (eq .Manifest.Platform "wordpress")}}
-		<div class="two fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_target_version"}}</label>
-				<input name="target_version" value="{{.Manifest.TargetVersion}}" placeholder="e.g. (5|6)\..*">
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_php_minimum"}}</label>
-				<input name="php_minimum" value="{{.Manifest.PHPMinimum}}" placeholder="e.g. 8.1">
-			</div>
-		</div>
-		{{end}}
-		{{end}}
-
-		<h5 class="ui dividing header">{{ctx.Locale.Tr "repo.settings.manifest_build"}}</h5>
-		<div class="three fields">
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_language"}}</label>
-				<select name="language" class="ui dropdown">
-					<option value="">—</option>
-					{{$lang := .Manifest.Language}}
-					{{range $val := StringUtils.Split "Go,PHP,TypeScript,JavaScript,Python,Ruby,Java,C#,Rust,Shell,SQL,CSS,HTML" ","}}
-						<option value="{{$val}}" {{if eq $val $lang}}selected{{end}}>{{$val}}</option>
-					{{end}}
-				</select>
-			</div>
-			{{if eq .Manifest.Platform "joomla"}}
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_package_type"}}</label>
-				<select name="package_type" class="ui dropdown">
-					<option value="">—</option>
-					{{$pkgType := .Manifest.PackageType}}
-					{{range $val := StringUtils.Split "component,module,plugin,package,template,library,file" ","}}
-						<option value="{{$val}}" {{if eq $val $pkgType}}selected{{end}}>{{$val}}</option>
-					{{end}}
-				</select>
-				<p class="help">{{ctx.Locale.Tr "repo.settings.manifest_package_type_help"}}</p>
-			</div>
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_element_full"}}</label>
-				<input name="element_name" value="{{.Manifest.ElementName}}" placeholder="{{.Manifest.AutoElementName}}">
-				{{if .Manifest.ElementNameMismatch}}
-					<p class="help tw-text-yellow-600">{{ctx.Locale.Tr "repo.settings.manifest_element_mismatch" .Manifest.AutoElementName}}</p>
-				{{else}}
-					<p class="help">{{ctx.Locale.Tr "repo.settings.manifest_element_full_help"}}</p>
-				{{end}}
-			</div>
-			{{end}}
-			<div class="field">
-				<label>{{ctx.Locale.Tr "repo.settings.manifest_entry_point"}}</label>
-				<input name="entry_point" value="{{.Manifest.EntryPoint}}" placeholder="e.g. ./ or src/index.ts">
-			</div>
-		</div>
-
-		<button class="ui primary button" type="submit">{{ctx.Locale.Tr "repo.settings.manifest_save"}}</button>
-	</form>
-</div>
-
-{{if .LicensingEnabled}}
-<h4 class="ui top attached header">
-	{{svg "octicon-broadcast" 16}} {{ctx.Locale.Tr "repo.settings.licensing_section"}}
-</h4>
-<div class="ui attached segment">
-	<form class="ui form" method="post" action="{{.RepoLink}}/settings/manifest?action=licensing">
-		{{.CsrfTokenHtml}}
-
-		<div class="inline field">
-			<div class="ui checkbox">
-				<input name="enable_licensing" type="checkbox" {{if and .RepoUpdateConfig .RepoUpdateConfig.LicensingEnabled}}checked{{end}}>
-				<label><strong>{{ctx.Locale.Tr "repo.settings.enable_licensing"}}</strong></label>
-			</div>
-			<p class="help">{{ctx.Locale.Tr "repo.settings.licensing_section_desc"}}</p>
-		</div>
-
-		<div class="ui divider"></div>
-
-		<div class="inline field">
-			<label>{{ctx.Locale.Tr "repo.settings.update_platform"}}</label>
-			<select name="update_platform" class="ui dropdown">
-				<option value="joomla" {{if or (not .RepoUpdateConfig) (eq .RepoUpdateConfig.Platform "joomla") (eq .RepoUpdateConfig.Platform "")}}selected{{end}}>Joomla (updates.xml)</option>
-				<option value="dolibarr" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "dolibarr")}}selected{{end}}>Dolibarr (JSON)</option>
-				<option value="wordpress" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "wordpress")}}selected{{end}}>WordPress (JSON)</option>
-				<option value="composer" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "composer")}}selected{{end}}>Composer (packages.json)</option>
-				<option value="prestashop" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "prestashop")}}selected{{end}}>PrestaShop</option>
-				<option value="drupal" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "drupal")}}selected{{end}}>Drupal</option>
-				<option value="both" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.Platform "both")}}selected{{end}}>{{ctx.Locale.Tr "repo.settings.update_platform_both"}}</option>
-			</select>
-			<p class="help">{{ctx.Locale.Tr "repo.settings.update_platform_help"}}</p>
-		</div>
-
-		{{if and .RepoUpdateConfig (ne .RepoUpdateConfig.Platform "joomla") (ne .RepoUpdateConfig.Platform "both") (ne .RepoUpdateConfig.Platform "")}}
-		<div class="inline field">
-			<div class="ui checkbox">
-				<input name="require_update_key" type="checkbox" {{if .RepoUpdateConfig.RequireKey}}checked{{end}}>
-				<label>{{ctx.Locale.Tr "repo.settings.require_update_key"}}</label>
-			</div>
-			<p class="help">{{ctx.Locale.Tr "repo.settings.require_update_key_help"}}</p>
-		</div>
-		{{end}}
-
-		<div class="inline field">
-			<label>{{ctx.Locale.Tr "repo.settings.download_gating"}}</label>
-			<select name="download_gating" class="ui dropdown">
-				<option value="none" {{if or (not .RepoUpdateConfig) (eq .RepoUpdateConfig.DownloadGating "") (eq .RepoUpdateConfig.DownloadGating "none")}}selected{{end}}>{{ctx.Locale.Tr "org.settings.download_gating_none"}}</option>
-				<option value="prerelease" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.DownloadGating "prerelease")}}selected{{end}}>{{ctx.Locale.Tr "org.settings.download_gating_prerelease"}}</option>
-				<option value="all" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.DownloadGating "all")}}selected{{end}}>{{ctx.Locale.Tr "org.settings.download_gating_all"}}</option>
-			</select>
-			<p class="help">{{ctx.Locale.Tr "org.settings.download_gating_help"}}</p>
-		</div>
-
-		<div class="inline field">
-			<label>{{ctx.Locale.Tr "repo.settings.feed_visibility"}}</label>
-			<select name="feed_visibility" class="ui dropdown">
-				<option value="public" {{if or (not .RepoUpdateConfig) (eq .RepoUpdateConfig.FeedVisibility "") (eq .RepoUpdateConfig.FeedVisibility "public")}}selected{{end}}>Public (show versions and downloads)</option>
-				<option value="no-download" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.FeedVisibility "no-download")}}selected{{end}}>No downloads (show versions only)</option>
-				<option value="hidden" {{if and .RepoUpdateConfig (eq .RepoUpdateConfig.FeedVisibility "hidden")}}selected{{end}}>Hidden (require license key)</option>
-			</select>
-		</div>
-
-		<div class="inline field">
-			<label>{{ctx.Locale.Tr "repo.settings.support_url"}}</label>
-			<input name="support_url" value="{{if .RepoUpdateConfig}}{{.RepoUpdateConfig.SupportURL}}{{end}}" placeholder="https://mokoconsulting.tech/support">
-			<p class="help">{{ctx.Locale.Tr "repo.settings.support_url_help"}}</p>
-		</div>
-
-		<div class="field">
-			<button class="ui primary button">{{ctx.Locale.Tr "save"}}</button>
-		</div>
-	</form>
-</div>
-{{end}}
-
-{{template "repo/settings/layout_footer" .}}