fix(auth): sign-in logo uses logo.svg (login-logo.png was 404)

jmiller commented

2026-07-18 23:30:06 +00:00

Owner

Fixes the missing sign-in logo.

templates/user/auth/signin_inner.tmpl referenced /assets/img/login-logo.png — a file that is never shipped (404) — so the sign-in page showed no logo (the onerror handler just hid the broken image). Switched to the existing logo.svg (200) with a logo.png fallback + alt text, matching templates/base/head_navbar.tmpl.

Not changed (deliberately): the sign-in a11y/theme-toggle icons render blank on git.dev — but that is deploy staleness, not a code bug. Font Awesome 7 is already vendored (web_src/css/vendor/fontawesome/) and @imported in web_src/css/index.css:6; the icons render on current code. git.dev shows them blank only because that container runs the stale stable-395 image (pre-theme). Fix = deploy current dev (see #816), not a template change — a "re-embed FA" PR would be redundant and would break prod (stable-439) where FA already loads.

Testing: sign-in page shows the MokoGIT logo; falls back to logo.png if svg unavailable.

Fixes the missing sign-in logo. `templates/user/auth/signin_inner.tmpl` referenced `/assets/img/login-logo.png` — a file that is never shipped (404) — so the sign-in page showed no logo (the `onerror` handler just hid the broken image). Switched to the existing `logo.svg` (200) with a `logo.png` fallback + alt text, matching `templates/base/head_navbar.tmpl`. **Not changed (deliberately):** the sign-in a11y/theme-toggle icons render blank on `git.dev` — but that is **deploy staleness, not a code bug**. Font Awesome 7 is already vendored (`web_src/css/vendor/fontawesome/`) and `@import`ed in `web_src/css/index.css:6`; the icons render on current code. `git.dev` shows them blank only because that container runs the stale `stable-395` image (pre-theme). Fix = deploy current dev (see #816), not a template change — a "re-embed FA" PR would be redundant and would break prod (`stable-439`) where FA already loads. Testing: sign-in page shows the MokoGIT logo; falls back to logo.png if svg unavailable.

jmiller added 1 commit 2026-07-18 23:30:09 +00:00

fix(auth): login logo points at missing login-logo.png -> use logo.svg

Universal: Auto Version Bump / Version Bump (push) Successful in 21s

Details

Universal: PR Check / Branch Policy (pull_request) Successful in 2s

Details

Generic: Project CI / Lint & Validate (pull_request) Successful in 43s

Details

Universal: PR Check / Validate PR (pull_request) Successful in 14s

Details

Universal: PR Check / Secret Scan (pull_request) Successful in 1m34s

Details

Branch Cleanup / Delete merged branch (pull_request) Has been skipped

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped

Details

Generic: Project CI / Tests (pull_request) Has been cancelled

Details

Universal: PR Check / Build RC Package (pull_request) Has been cancelled

Details

Universal: PR Check / Report Issues (pull_request) Has been cancelled

Details

4dc8ca7223

templates/user/auth/signin_inner.tmpl referenced /assets/img/login-logo.png,
which is never shipped (404) — so the sign-in page rendered with no logo (the
onerror just hid it). Use the existing logo.svg (with a logo.png fallback and
alt text), matching templates/base/head_navbar.tmpl.

Note: the sign-in a11y/theme-toggle icons are NOT a code bug — Font Awesome 7 is
vendored (web_src/css/vendor/fontawesome) and @imported in index.css:6; they
render blank only on git.dev because that container runs the stale stable-395
image (pre-theme). Fixed by deploying current dev (see #816), not a template change.

Authored-by: Moko Consulting

jmiller commented

2026-07-18 23:46:56 +00:00

Author

Owner

Superseded by #823 (login retheme), which absorbs this same logo fix (login-logo.png -> logo.svg) and edits the same signin_inner.tmpl. Closing to avoid a merge conflict; the logo fix lives on in #823.

jmiller closed this pull request

2026-07-18 23:46:57 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

fix(auth): sign-in logo uses logo.svg (login-logo.png was 404) #821

Pull request closed